The Unapologetic Code Reviewer...
Anonymous Tipsy Wallflower #944 · General
So there's this thing at work where I'm known for being a bit of an unyielding code reviewer. You see, when someone submits a change to the project and it doesn't meet my standards, or rather, our agreed-upon coding conventions, I don't hold back on criticizing the PRs (pull requests). It's not like I mean to be a jerk or anything... but sometimes, I just can't help myself... there are these moments where you see someone write code that's so far from what we've established as 'the way' and it's like... how did this even get to me? Anyway, last week was the worst. My colleague Alice submitted a PR with some really clunky logic that would have made the system less efficient... by quite a bit. I mean, it wouldn't crash anything... but still... It's just not acceptable in my book... So I left this huge comment on her PR saying exactly what was wrong and how to fix it. Of course, Alice is usually pretty chill about these things, but she came into my office the next day with a look of complete bewilderment and irritation on her face... It was like, 'What's going on here?'... I tried to explain that I'm just following our guidelines and ensuring we maintain high-quality standards. But Alice said something pretty cutting, she mentioned how I come off as overly critical without offering much constructive feedback or help in improving the code... Now... I mean... I've never really thought of myself this way... but after her comment, it kind of hit me hard that maybe there's some validity to what she's saying. That said, I'm still not convinced changing my approach would be better for everyone... So yeah... that's the confession. I'm unapologetically critical in code reviews and sometimes people get frustrated with me because of it... but hey... someone has to ensure our project doesn't turn into a mess of spaghetti code... right?...